fix: login with furl

polylan_submitter/simple_cas_backend.py

@@ -7,6 +7,7 @@ import requests
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.contrib.auth.backends import BaseBackend
+from furl import furl
 
 
 class SimpleCASBackend(BaseBackend):

polylan_submitter/simple_cas_views.py

@@ -7,7 +7,7 @@ from django.contrib.auth import authenticate, login, logout
 from django.shortcuts import redirect
 from django.http import HttpResponse
 from django.views import View
-import urllib.parse
+from furl import furl
 
 
 class SimpleCASLoginView(View):
@@ -35,8 +35,9 @@ class SimpleCASLoginView(View):
             service_url = request.build_absolute_uri().split("?")[
                 0
             ]  # Remove query params
-            cas_login_url = f"{settings.CAS_SERVER_URL.rstrip('/')}/login?service={urllib.parse.quote(service_url)}"
-            return redirect(cas_login_url)
+            cas_login_url = furl(settings.CAS_SERVER_URL) / "login"
+            cas_login_url.set(args={"service": service_url})
+            return redirect(cas_login_url.url)
 
 
 class SimpleCASLogoutView(View):